Skip to content

add default values to several db table columns

Thomas Hauschild requested to merge add-default-values-for-seed into master

What does this MR do?

It adds default values for several columns which are needed for the seed.

How confident are you it won't break things if deployed?

99,9% since it only affects the dev environment. (Or every system that uses phinx)

Links to related issues

https://yunity.slack.com/archives/C1T1ZM9A4/p1647529600298569

How to test

Check if scripts/seed still runs.

Bonus points if it does run with enabled sql_mode: https://gitlab.com/foodsharing-dev/foodsharing/-/blob/master/docker/conf/db/ci.cnf#L17 (That's what this MR is actually all about)

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • used "state:" labels to track this MR's state until it was beta tested
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Einige Standardwerte für Spalten der Entwicklungs-Datenbank gesetzt.

Edited by Thomas Hauschild

Merge request reports