Skip to content

Log who deleted a profile

Alex requested to merge foodsaver-deleted-by into master

What does this MR do?

Adds 'deleted_by' and 'deleted_reason' columns to 'fs_foodsaver'. 'deleted_by' stores the Id of the user who deleted a profile. 'deleted_reason' stores an optional text that the deleting user can type in.

screenshot

screenshot2

How confident are you it won't break things if deployed?

Should work

How to test

  1. Checkout branch locally
  2. Run the migration with ./scripts/docker-compose exec app vendor/bin/phinx migrate
  3. Login as userorga
  4. Go to any user profile, edit it (menu on the left), and delete it (right side). This should only work if you add a reason text.
  5. Do the same in your own profile. There the dialog does not ask for a reason text.
  6. Have a look at fs_foodsaver in http://localhost:18081. The entry should contain a foodsaver_id now.

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • used "state:" labels to track this MR's state until it was beta tested
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Zur Nachvollziehbarkeit wird in Zukunft gespeichert, wer ein Profil gelöscht hat.

Edited by Alex

Merge request reports