Skip to content

Resolve "Error page when trying to resend an activation email"

ESchae requested to merge 1136-error-page-when-trying-to-resend-an-activation-email into master

Closes #1136 (closed)

What does this MR do?

When I am not logged in, the page https://foodsharing.de/?page=login&a=resendActivationMail redirects to the login page.

How confident are you it won't break things if deployed?

I would actually prefer to add a small unit test, but I could not figure out where to best put the test. Manually adding / removing the changes and testing its effects in the browser did not relibly work for me, even after deleting the cache like described in https://devdocs.foodsharing.network/troubleshooting.html.

At least it worked in the beginning and moreover its a very small change, therefore I am relatively confident... .

How to test

  1. Checkout branch locally
  2. Go to http://localhost:18080/?page=login&a=resendActivationMail
  3. Check that you see the login page instead of an 500 error page

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • used "state:" labels to track this MR's state until it was beta tested
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Bei Klick auf den Link zum erneuten Senden der Aktivierungsmail wirst du zum Login weitergeleitet, falls du vorher nicht eingeloggt warst.

Edited by ESchae

Merge request reports