Skip to content

Send out bell notifications asynchronously

Alex requested to merge async-bell-notifications into master

Closes #1069 (closed), probably closes #1141 (closed)

What does this MR do?

A lot of requests to the server, including the confirmation of slots, are slow because the backend creates a bell and has to send out notifications via websocket. Sending those notifications can take a while. The library Guzzle that we use for this provides methods for sending asynchronously, which I used here for the bell notifications.

How confident are you it won't break things if deployed?

This is more like a proposal. I think it should work, but there might be side effects like bells that don't appear.

How to test

  • Test the slot confirmation that is described in #1141 (closed)
  • Test if anything regarding bells and the chat still works

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • used "state:" labels to track this MR's state until it was beta tested
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Edited by Alex

Merge request reports