Remove obsolete picture upload code

What does this MR do?

Since !2089 (merged) and !1916 (merged), the upload of profile pictures and pictures for blog posts is done with the new API. This removes a lot of old code that is not in use anymore.

How confident are you it won't break things if deployed?

Very sure. This removes the functions pictureCrop and pictureReady, which are not used anywhere.

How to test

Not really possible, because the code is not used anymore. You can check all picture uploads are still possible (profile pictures, wall posts, blog posts, ...)

Checklist

• added a test, or explain why one is not needed/possible...
• no unrelated changes
• asked someone for a code review
• set a "for:" label to indicate who will be affected by this change
• used "state:" labels to track this MR's state until it was beta tested
• added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
• added an entry to CHANGELOG.md
• added a short text that can be used in the release notes
• Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
  • Consider writing a detailed description in German.
  • Describe in a few sentences, what should be tested from a user perspective.
  • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
  • Be aware, that also non technical people should understand.

Release notes text in German

client/src/script.js

@@ -336,58 +336,6 @@ export function closeBox () {
   $.fancybox.close()
 }
 
-export function pictureReady (id, img) {
-  $(`#${id}-preview`).html(`<img src="images/${id}/thumb_${img}" />`)
-  $(`#${id}`).val(`${id}/${img}`)
-
-  $.fancybox.close()
-  hideLoader()
-}
-
-export function pictureCrop (id, img) {
-  const ratio = $.parseJSON($(`#${id}-ratio`).val())
-  const ratio_val = $.parseJSON($(`#${id}-ratio-val`).val())
-
-  const ratio_i = parseInt($(`#${id}-ratio-i`).val())
-
-  if (ratio[ratio_i] != undefined) {
-    $(`#${id}-ratio-i`).val((ratio_i + 1))
-    $(`#${id}-crop`).html(`<img src="images/${id}/${img}" /><br /><span id="${id}-crop-save">Speichern</span>`)
-    $(`#${id}-crop img`).Jcrop({
-      setSelect: [100, 0, 400, 400],
-      aspectRatio: ratio[ratio_i],
-      onSelect: function (c) {
-        $(`#${id}-x`).val(c.x)
-        $(`#${id}-y`).val(c.y)
-        $(`#${id}-w`).val(c.w)
-        $(`#${id}-h`).val(c.h)
-      },
-    })
-    hideLoader()
-    setTimeout(function () {
-      $.fancybox.update()
-      $.fancybox.reposition()
-      $.fancybox.toggle()
-    }, 200)
-
-    $(`#${id}-crop-save`).button().on('click', function () {
-      ratio_val[ratio_val.length] = {
-        x: Math.round($(`#${id}-x`).val()),
-        y: Math.round($('#' + id + '-y').val()),
-        w: Math.round($('#' + id + '-w').val()),
-        h: Math.round($('#' + id + '-h').val()),
-      }
-      $(`#${id}-ratio-val`).val(JSON.stringify(ratio_val))
-
-      pictureCrop(id, img)
-    })
-  } else {
-    showLoader()
-    $(`#${id}-form`).attr('action', `/xhr.php?f=pictureCrop&id=${id}&img=${img}`)
-    $(`#${id}-form`).trigger('submit')
-  }
-}
-
 export function u_loadCoords (addressdata, func) {
   let anschrift = ''
   if (addressdata.str != undefined) {