Skip to content

Add Utility Class to format numbers according to selected language

Anton Ballmaier requested to merge number-formatting into master

Closes #1169 (closed)

What does this MR do?

Adds a new Utility / Helper class providing methods for formatting plain numbers and distances. Number formatting functions may be added in the future. Also more translations may be added later. Currently only german and english are provided. This helper function is already used to replace many occurences of number_format.

How confident are you it won't break things if deployed?

I tried out the formatting functions and am confident that they work as expected. I have however not tested every occurence where I used the function, so there I am not 100% confident. But 95 ;)

How to test

Have a look at the site, for example at /statistik. You can see the number format changing when you switch the language.

Screenshots (if applicable)

German: image

English: image

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • used "state:" labels to track this MR's state until it was beta tested
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Die Zahlendarstellung ist nun von der Sprache abhängig. Im Englischen wird bspw. 1.234 jetzt als 1,234 dargestellt.

Merge request reports