Do not deverify unverified users
What does this MR do?
Foodsavers who are not (yet) verified will deverify themselves when changing the home region. That adds an unnecessary "deverified at..." entry to the verification history (see the screenshot). This MR makes sure that the entry is only added if the foodsaver's state was actually changed.
from https://foodsharing.freshdesk.com/a/tickets/2542
How confident are you it won't break things if deployed?
Very sure
How to test
- Checkout branch locally
- Login as user1
- Leave your home region
- Login as userorga
- Check the verification history of user1 -> there should be no entry
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
used "state:" labels to track this MR's state until it was beta tested -
added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label) -
added an entry to CHANGELOG.md -
added a short text that can be used in the release notes -
Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing". - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.