Skip to content

Add store address to iCalendar pickup events

Thomas requested to merge 1139-iron9-store-address-in-icalendar into master

Closes #1139 (closed)

What does this MR do?

iCalendar events now contain the address of the store.

How confident are you it won't break things if deployed?

60% (getNextDates() is used multiple times. I'm not sure whether it is okay to extend it like I did.)

Links to related issues

How to test

  1. Checkout branch locally
  2. Login as foodsaver
  3. Fill any slot in any store
  4. Go to settings, calendar, create a token and subscribe to the calendar with an external program or App.
  5. Check in the event corresponding to the slot that the location field is filled with the address of the store.

Screenshots (if applicable)

grafik

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • used "state:" labels to track this MR's state until it was beta tested
  • added to the next milestone (see https://gitlab.com/foodsharing-dev/foodsharing/-/milestones, unless it has a "for:Dev" label)
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum. Please change the MRs label to "state:Beta testing".
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text in German

Wenn du deine Abholungen per iCalendar in einem Kalenderprogramm oder einer App anschaust, wird dort auch die Adresse angezeigt.

Edited by Thomas

Merge request reports