Skip to content

Draft: Remove old database functions

Alex requested to merge 9-remove-deprecated-db into master

Part of #9 (closed)

What does this MR do?

Some code cleanup: two of the deprecated database functions in the Db class are only used in two instances. I removed them and added functions in Gateway classes instead.

How confident are you it won't break things if deployed?

Very sure. The functions used very simple SQL queries.

Links to related issues

How to test

This affects two things: changing the pickups of a store and adding a new mailbox.

For the first:

  1. Checkout branch locally
  2. Login as storemanager1 or userstorecoordination1
  3. Go to a store which you coordinate
  4. Change the regular pickups and check that the old ones were successfully removed

For the second:

  1. Login as userorga
  2. Go to the mailbox management page http://localhost:18080/?page=mailbox&a=manage
  3. Create a new mailbox and check that it was successfully created

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • used "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • added a short text that can be used in the release notes for::Dev
  • Once your MR has been merged, you are responsible to create a testing issue in the Beta Testing forum: https://foodsharing.de/?page=bezirk&bid=734&sub=forum
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
    • Be aware, that also non technical people should understand.
Edited by Alex

Merge request reports