Follow-up fixes for the store page
Two parts of #1084 (closed)
What does this MR do?
- Fixes the permissions for the "send message to team" and "send message to jumpers" buttons. They are now visible for team members and jumpers again.
- Fixes the notification that is shown for Orga when opening a store page.
How confident are you it won't break things if deployed?
I tested it for jumpers, team members, store managers, orga. There might be special cases that I didn't think of.
How to test
For the chat permissions: the two buttons should be visible for certain groups:
| jumper | team member | store manager | admin of store coordination group | orga | |
|---|---|---|---|---|---|
| "send to jumper" | x | x | x | x | |
| "send to team" | x | x | x | x |
- check out branch locally
- log in as a member of one of the groups above (see https://devdocs.foodsharing.network/setting-things-up.html#setting-things-up for user roles). You might have to send a store member to the jumper list first.
- go to a store and check if you can see the buttons
For the notification fix:
- log in as userorga
- go to any store
- check that you see a notification
- check that you see a different message for userstorecoordination1
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
used "state:" labels to track this MR's state until it was beta tested -
added an entry to CHANGELOG.md -
added a short text that can be used in the release notes(only on beta) -
Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo: - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...) how this change can be tested.
- Be aware, that also non technical people should understand.