Skip to content

Workaround for "Persistent sessions are a problem for the last login date"

Thomas Hauschild requested to merge 956-enable-session-cookie-checkbox into master

What does this MR do?

Enable session cookie checkbox and remove cookie update on every request

More detailed info: #956 (comment 649029515)

How confident are you it won't break things if deployed?

I did not create the initial feature, so I cannot answer that, but you need to consider #956 (closed) first and my comment from above.

For the workaround alone I'd go for 99% since I tested it thoughtfully.

Links to related issues

#956 (comment 649029515)

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Set 1 day to a shorter time: https://gitlab.com/foodsharing-dev/foodsharing/-/blob/956-enable-session-cookie-checkbox/src/Lib/Session.php#L54
  2. Use the persistent session checkbox at login
  3. Check if you're automatically logged out after set expiration time from step 1 (after reloading the page manually of course)

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • add a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text

Re-enabled cookie session checkbox with persistent cookie duration for 2 weeks

Edited by Thomas Hauschild

Merge request reports