Skip to content

Allow admins of the newsletter group to see the full region tree

Alex requested to merge newsletter-tree-permission into master

What does this MR do?

In the newsletter module you can select specific regions to which the newsletter will be sent. However, the list was only accessible for orga, not for members of the newsletter group.

For testing, I added user2 as admin of the newsletter group to the seed data.

How confident are you it won't break things if deployed?

Very sure

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Checkout branch locally
  2. Login as user2
  3. Go to Administration -> Newsletter
  4. Select "Bezirke einzeln auswählen"
  5. You should be able to see the full region tree

Checklist

  • added a test, or explain why one is not needed/possible... it's still an old Xhr endpoint. We should add a unit test when we changed it to Rest.
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • add a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text

Admins der Newsletter AG können jetzt Newsletter an alle Bezirke versenden.

Merge request reports