Skip to content

Bugfixes for PHP type errors

Alex requested to merge sentry-bugfixes into master

What does this MR do?

Adds some type checks that prevent argument type errors in PHP, i.e. errors like Argument 2 ... must be of the type int, null given. I'm guessing these happen when there is inconsistent data or if a link is not copied correctly.

How confident are you it won't break things if deployed?

Very sure

How to test

I don't think these can be easily tested

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • add a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text

(A short text that will appear in the release notes and describes the change for non-technical people. Not always necessary, e.g. not for refactoring.)

Edited by YertleTurtleGit

Merge request reports