Removed duplicate entries by tracking already added ones
What does this MR do?
Closes #1063 (closed). Fixes a bug on the page /?page=fsbetrieb
which caused stores show up multiple times under the category "other stores".
How confident are you it won't break things if deployed?
8/10. I don't think this will break anything at all. Stores are not getting removed from the array, just ignored if they are already inserted. 8/10 only because it's my fist submission and you never know...
Links to related issues
See #1063 (closed) for reference.
How to test
- Checkout branch locally
- Login as a user with role
foodsaver
- Go to page
/?page=fsbetrieb
- Check for duplicate entries in category "other stores"
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
use "state:" labels to track this MR's state until it was beta tested -
added an entry to CHANGELOG.md -
add a short text that can be used in the release notes -
Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo: - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
- Be aware, that also non technical people should understand.
Release notes text
Removes a bug that causes some of your stores to show up falsely multiple times.
Edited by Bjarne Schindler