Skip to content

Fix passport generation with new uploaded photos

Alex requested to merge fix-profile-photo-passports into master

Closes #461 (closed), follow-up from !1916 (merged)

What does this MR do?

Profile photos are now being uploaded with the upload API, but the passport generator is still using only the old photos. This MR allows the generator to also handle file paths from the new API.

How confident are you it won't break things if deployed?

Should work. Essentially, this is using the same code as the one that displays the profile photo on the website.

How to test

  1. Checkout branch locally
  2. Login as foodsaver
  3. Go to your profile settings
  4. Upload a new profile picture
  5. Login as userbot
  6. Go to the passport list
  7. Create a new passport for the foodsaver
  8. The passport should contain the photo

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • add a short text that can be used in the release notes (combined with !1916 (merged))
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text

(A short text that will appear in the release notes and describes the change for non-technical people. Not always necessary, e.g. not for refactoring.)

Edited by Alex

Merge request reports