Skip to content

Draft: Improve business card creation

Alex requested to merge business-card-options into master

What does this MR do?

Some improvements for the business cards:

  • a new vue component that allows selecting which information should be on the card
  • fewer spaghetti code in the gateway
  • have the backend only put selected information onto the card
  • add a QR code containing a vCard
  • use standardised format of 10 cards per DIN A4 page

How confident are you it won't break things if deployed?

not perfectly sure, this has to be tested with roles and regions

Links to related issues

Discussion in Produkt-AG: https://foodsharing.de/?page=bezirk&bid=2296&sub=forum&tid=122667&pid=760582#post-760582

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Checkout branch locally
  2. Login as foodsaver
  3. Go to Account -> Settings -> Business cards
  4. Make sure that all options in the dropdown are correct
  5. Create a card and make sure that it looks correct

Screenshots (if applicable)

cards

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • add a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text

(A short text that will appear in the release notes and describes the change for non-technical people. Not always necessary, e.g. not for refactoring.)

Edited by Alex

Merge request reports