Remove obsolete code for picture uploads
Closes #261 (closed), part of &4 (closed)
What does this MR do?
Removes a lot of obsolete PHP and JS code that is no longer in use since we changed the profile picture upload in !1916 (merged). This closes #261 (closed) because xhr_cropagain
is removed, too.
How confident are you it won't break things if deployed?
Not perfectly sure, but everything seems to work for me
How to test
Steps a reviewer can take to verify that this MR does what it says it does e.g.
- Checkout branch locally
- Login as userorga
- There are six cases where pictures are uploaded. Check all of them if they still work:
- replace your profile picture
- add or edit a blog post
- add or edit a basket
- post on a wall (e.g. on your profile)
- change the title picture of a foodsharepoint
- change the title picture of a working group
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
use "state:" labels to track this MR's state until it was beta tested -
added an entry to CHANGELOG.md -
add a short text that can be used in the release notes -
Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo: - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
- Be aware, that also non technical people should understand.
Release notes text
(A short text that will appear in the release notes and describes the change for non-technical people. Not always necessary, e.g. not for refactoring.)
Edited by Alex