Skip to content

fix issue 1076 by excluding wall post author from team members' array

Closes #1076 (closed)

What does this MR do?

exclude store wall post author from bell notification receivers

How confident are you it won't break things if deployed?

./scripts/test-rerun tests/api/StoreApiCest.php:canWriteStoreWallpostAndGetAllPosts --debug fails locally for me with 401 unauthorized

But as tests/api/StoreApiCest.php:canWriteStoreWallpostAndGetAllPosts passes in pipeline, it should not break anything.

I assume an additional test case is not needed as the test case :canWriteStoreWallpostAndGetAllPosts already exists.

Links to related issues

none

How to test

Automated test: ./scripts/test tests/api/StoreApiCest.php:canWriteStoreWallpostAndGetAllPosts --debug

Manual test:

  1. Checkout branch locally
  2. Login as foodsaver
  3. Add a new store wall post
  4. Assertion 1: You shouldn't receive a notification.
  5. Logout and login as another foodsaver part of the store.
  6. Assertion 2: This other foodsaver should have received a notification. (couldn't execute locally as login fails)

Screenshots (if applicable)

none

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • add a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text

Before this release, you may have received notifications for your own store wall posts. Now, if you add a post to a store wall, every member of the store will receive a bell notification except you.

Edited by Fabian Rudolf

Merge request reports