Skip to content

Lazy load data for the region picker

Alex requested to merge change-region-picker-behavior into master

Closes #823 (closed)

What does this MR do?

Makes the region picker load its data (the top level regions) only when it is opened. This saves us one database request on every page load.

How confident are you it won't break things if deployed?

This can't break a lot and it works for me without any warnings

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Checkout branch locally
  2. Login as foodsaver
  3. Use the region picker in the menu to join any region

Checklist

  • added a test, or explain why one is not needed/possible... -> is covered by FoodsaverCanJoinRegion.php
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • add a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.

Merge request reports