Skip to content

Explain what an unconfirmed pickup means in the popup of a slot

blinry requested to merge explain-unconfirmed-pickups into master

This MR is not connected to an existing issue.

What does this MR do?

It adds an explanatory text to the popup of an unconfirmed slot, saying that a store manager needs to confirm it. The meaning of the red clock icon is otherwise not discoverable via the existing UI.

How confident are you it won't break things if deployed?

The testsuite seems to pass, and this is a frontend-only change.

Links to related issues

Short Slack discussion

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Checkout branch locally
  2. Login as foodsaver
  3. Sign up for a new slot in a company
  4. Observe the popup text

Screenshots (if applicable)

Checklist

  • added a test, or explain why one is not needed/possible...
    • From my point of view, this feature seems to have to small of a scope to require a test. But please comment if you disagree!
  • no unrelated changes
  • asked someone for a code review -> on Slack
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • add a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text

For unconfirmed pickup slots, explain in the popup text that a store manager still has to confirm it.

Edited by blinry

Merge request reports