Skip to content

Fix profile picture

Alex requested to merge profile-image-fix into master

Another follow-up for !1916 (merged)

What does this MR do?

Fixes the use of profile pictures that were uploaded with the new API:

  • when sending a trust banana
  • in the member list of regions / working groups
  • in the nightly maintenance script where unused pictures are being deleted
  • refreshes the session after setting a new profile photo

How confident are you it won't break things if deployed?

Quite sure. Won't make anything worse

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Checkout branch locally
  2. Login as foodsaver
  3. Upload a new profile photo
  4. Go to someone else's profile and send a banana -> you should see your own photo in the list
  5. Go to the member list of a region in which you are a member -> you should see your own photo in this list, too

Screenshots (if applicable)

Any relevant screenshots if this is a design / frontend change

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • add a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text

(A short text that will appear in the release notes and describes the change for non-technical people. Not always necessary, e.g. not for refactoring.)

Edited by Alex

Merge request reports