Skip to content

Make bananas deletable

Alex requested to merge 592-delete-bananas into master

Closes #592 (closed)

What does this MR do?

Bananas can be removed by a button next to them in the banana list. For now, it is only possible to remove bananas that you received on your own profile, but we can change the permissions if needed.

I added some bananas to the seed data for testing.

How confident are you it won't break things if deployed?

I can't think of anything that would break here. It should work.

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Checkout branch locally
  2. Run ./scripts/seed to add some bananas
  3. Login as foodsaver
  4. Go to your profile page
  5. Open the banana list
  6. Click the delete button (trash bin) next to an entry and confirm in the next dialog
  7. Reload the page and check that the banana is gone

Screenshots (if applicable)

1

2

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • add a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text

(A short text that will appear in the release notes and describes the change for non-technical people. Not always necessary, e.g. not for refactoring.)

Edited by Alex

Merge request reports