Skip to content

Fix DTOs that are used for dashboard updates

Alex requested to merge dashboard-dto-time into master

What does this MR do?

There is a bug in the DTOs that are used for dashboard updates since the release: https://sentry.io/share/issue/9aecc64081fe4dd19e96076752904008/. That is probably also the reason why some people don't see any updates on their dashboard anymore (https://foodsharing.freshdesk.com/a/tickets/1372).

This refactors the DTOs (ActivityUpdate.php and ActivityUpdateMailbox.php) to use DateTime objects instead of time strings, which probably also fixes the problem.

How confident are you it won't break things if deployed?

Won't make things worse. The refactoring was planned anyway since !1767 (merged). I'm not sure if this will fix the bug, but it is worth a try.

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Checkout branch locally
  2. Login as foodsaver
  3. See if your dashboard is showing updates

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • add a short text that can be used in the release notes (refactoring)
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.
Edited by Alex

Merge request reports