Skip to content

Fix the address picker after upgrading dependencies

Fridtjof requested to merge fix-address-suggestions into master

What does this MR do?

https://github.com/komoot/typeahead-address-photon/commit/f07494ba164b7ec9d140ffec7f4e8eb6efa4a4b9

The package maintainers did kind of a bad job explaining the full refactor they did for their 1.1 version, so the way we previously imported that package just stopped working. They don't even have release notes x_x

Anyway, I """fixed""" it, but now it pollutes window namespace for no reason :/ I guess we'll just have to deal with it and hope they'll find out about release notes in the future...

How confident are you it won't break things if deployed?

it fixes something that broke earlier :D

Links to related issues

https://yunity.slack.com/archives/C74JC2V26/p1612953770021900

#1047

How to test

test the address field and suggestions on any form that has them (store edit/add, ...)

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md

(no release notes, this fixes something which broke in this release)

Edited by Fridtjof

Merge request reports