Skip to content

Remove users from pickup slots on deletion

Alex requested to merge pickup-signout-on-deletion into master

What does this MR do?

Makes sure that a user who is deleted is removed from all store teams and future pickup slots. Previously, the slots were left assigned to the deleted user.

Was noticed in https://foodsharing.freshdesk.com/a/tickets/1160

How confident are you it won't break things if deployed?

Quite sure, I added a unit test

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Checkout branch locally
  2. Login as foodsaver
  3. Sign in to some slots in a store
  4. Go to settings -> delete account
  5. Login as userbot
  6. Check if the slots are free again

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • add a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text

Wenn sich Benutzer löschen, werden die Abholungen, in die sie eingetragen sind, wieder freigegeben.

Merge request reports