Skip to content

Hide map label only for FS-role or on mobile

Joanna Gabiś requested to merge display-map-label into master

Closes #1043 (closed)

What does this MR do?

Hides map label in topbar if user is FS or is on mobile. Otherwise the label should be visible.

How confident are you it won't break things if deployed?

It is a tiny change show it should break anything but it is my first MR so I cannot be 100% sure

Links to related issues

It should fix #1043 (closed)

How to test

  1. Checkout branch locally
  2. Login as foodsaver and check if the label is hidden
  3. Login with some other role and check if the label is visible on desktop and hidden on mobile

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • add a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text

Das Label für Menüpunkt 'Karte' im Topbar wird immer angezeigt, außer für die Rolle Foodsaver und auf Mobilgeräten.

Edited by Joanna Gabiś

Merge request reports