Skip to content

New endpoint for map markers

Alex requested to merge map-marker-endpoints into master

Part of &9

What does this MR do?

Moves the requests for map markers to a new REST endpoint and removes some of the old Xhr code. Also adds a DTO for the markers. The behavior of the map should still be the same.

How confident are you it won't break things if deployed?

Works for me, but I would be happy about feedback

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Checkout branch locally
  2. Login as foodsaver
  3. Go to the map http://localhost:18080/karte
  4. Change some of the checkboxes and check if the correct markers show up
  5. Click some of the markers to check if they work as expected

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • add a short text that can be used in the release notes (for:Dev)
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text

(A short text that will appear in the release notes and describes the change for non-technical people. Not always necessary, e.g. not for refactoring.)

Edited by Alex

Merge request reports