Skip to content

if storewall user is deleted show 'abgemeldeter Benutzer' as name

- requested to merge activityupdate_fix into master

What does this MR do?

If a user is deleted his store entries are still shown, this cased a failure with the activity loader

How confident are you it won't break things if deployed?

quite

Links to related issues

Any relevant links (issues, documentation, slack discussions).

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Checkout branch locally
  2. Login as userbot

3a. Check store wall for last entry user

3b. Check for fairsharepoint wall last entry user

buddywallpost can't happen since when the user is deleted the fs_buddy entries are deleted.

forumpost - entries from deleted useres are not loaded.

mailaddress change can not happen.

  1. Login as last entry user (or userorga)
  2. Delete users under 3a/b
  3. Login as userbot
  4. Go to store update,fairsharepoint - it should show "abgemeldeter Benutzer" instead of crashing.

Screenshots (if applicable)

image image

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • add a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text

(A short text that will appear in the release notes and describes the change for non-technical people. Not always necessary, e.g. not for refactoring.)

Edited by -

Merge request reports