Change forum thread active flag to status
What does this MR do?
Renames the 'active' flag in 'fs_theme' for forum threads to 'status' and adds an enum with possible status values. The intention is that this is not a boolean flag anymore, but can contain additional values like "closed" as a preparation for !1851 (merged) . Threads can then have a lifecycle NOT_ACTIVATED (0) -> OPEN (1) -> CLOSED (2)
How confident are you it won't break things if deployed?
Quite sure, unless there are use cases that I haven't thought of
How to test
Steps a reviewer can take to verify that this MR does what it says it does e.g.
-
Checkout branch locally
-
Login as foodsaver
-
Go to a forum and create a thread
-
The thread should be open and visible
-
Create a thread in a moderated forum (set 'moderated'=1 in 'fs_region') -> the thread should not be visible yet
-
Login as userbot
-
go to http://localhost:18084, open the activation email, and activate the thread
-
Login as foodsaver again -> the thread should now be visible
Checklist
-
added a test, or explain why one is not needed/possible...there are unit tests for this -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
use "state:" labels to track this MR's state until it was beta tested -
added an entry to CHANGELOG.md -
add a short text that can be used in the release notes -
Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:- Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
- Be aware, that also non technical people should understand.
Release notes text
(A short text that will appear in the release notes and describes the change for non-technical people. Not always necessary, e.g. not for refactoring.)