Skip to content

Convert regular slots to manual slots as soon as someone joins an empty slot

Chris Oelmueller requested to merge 860-pickup-change into master

What does this MR do?

  • Please review commit-by-commit!

When adjusting the pickup schedule in a store, right now, the old recurring slots vanish from the store view. That's bad, because they still exist (and show up on the dashboard and profile for users!), and it causes lots of confusion.

Instead of a huge refactoring, use the following "convert to onetime pickup" hack:

  • when somebody signs into any slot, the associated pickup is converted to a onetime pickup
  • this pickup stays "manual" even if people leave slots again, but can easily be cleaned up

So now, when adjusting a store's pickup schedule, people who signed into slots that no longer will be generated will still be visible in the store. They can either be signed out and notified, or treat this as "reservation claim" for the new slot if it was just a minor change in time.

How confident are you it won't break things if deployed?

99% give or take. The hack is ugly design-wise but I cleaned up some code to make up for it.

Links to related issues

Related tickets

How to test

See above ;-)

Checklist

  • adjusted test cases accordingly
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • add a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text

(A short text that will appear in the release notes and describes the change for non-technical people. Not always necessary, e.g. not for refactoring.)

Edited by Jessica Heyer

Merge request reports