Skip to content

Deleteregionfix

- requested to merge deleteregionfix into master

Closes #1018 (closed)

What does this MR do?

Fixes a bug introduced with 0f816af7. It also no longer unverifies a user if they are removed by someone else (a bot for example) - this was the previous behavior before 0f816af7, which was only intended to unverify users that removed themselves from their home district.

How confident are you it won't break things if deployed?

(be honest!)

Links to related issues

Any relevant links (issues, documentation, slack discussions).

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Checkout branch locally
  2. Login as ambassador
  3. Remove foodsaver from region
  4. No entry in verification histroy

Screenshots (if applicable)

Any relevant screenshots if this is a design / frontend change

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • add a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text

Wenn ein Botschafter einen foodsaver aus dem Bezirk entfernt über die "foodsaver" Übersicht , verliert dieser nicht mehr die Verifizierung und es wird keine falsche Historie geschrieben.

Edited by -

Merge request reports