Skip to content

Resolve "Notifications for Trust banana"

Michel Vielmetter requested to merge 548-trust-banana into master

Release notes text

Wenn du eine neue Vertrauensbanane erhalten hast, wirst du darüber nun per Glocke benachrichtigt. Außerdem haben wir die Anzeige der vergebenen Bananen weiter modernisiert.

What does this MR do?

Introduces Bell notifications for trust bananas

Closes #548 (closed)

How confident are you it won't break things if deployed?

I only changed 2 lines of working code and the rest is my own logic, so not much should be breakable by this task. The thing that could break is the test I wrote as I'm not very good with that yet. (See UserApiCest->canGiveBanana())

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Checkout branch locally
  2. Login as bot
  3. Give trust banana to user One
  4. Login as user one and check Bell

Beta Testing: foodsharing-beta-testing#40

Screenshots

Screenshot_2020-12-04_at_17.51.06

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • add a short text that can be used in the release notes
  • Beta Issue: foodsharing-beta-testing#40
Edited by Chris Oelmueller

Merge request reports