Skip to content

Updates for the voting tool

Alex requested to merge 975-voting-tool-fixes into master

Part of #975

What does this MR do?

  • Change buttons in thumbs-voting to outlined version to make the selection more visible outline-secondary

  • move poll metadata above the description text and make the "you have already voted" text more visible image

  • change the "verified Foodsavers with home region" scope so that users who have their home district in any subregion will be included as well

How confident are you it won't break things if deployed?

I'm quite sure that the frontend changes won'tt break anything. The changes in the scope need some testing.

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

For the frontend changes:

  1. Checkout branch locally
  2. Login as foodsaver
  3. Go to Göttingen -> Abstimmungen
  4. Open a poll that uses the thumb voting and check if the buttons and the layout look correct

For the change in the scope:

  1. Login as user2 and join the region "Stadtteil von Göttingen"
  2. Change the home region of user2 in the database to "Stadtteil von Göttingen":
  • find that region's id in fs_bezirk
  • change the bezirk_id of user2 in fs_foosaver to the new value
  1. Login as userbot and create a poll in Göttingen with scope "verified Foodsavers with home region"
  2. Login as user2 again -> you should be invited to the poll (bell notification) and be able to vote

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • add a short text that can be used in the release notes (combined with voting tool)
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo: (will be done in beta testing group)
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.
Edited by Chris Oelmueller

Merge request reports