Skip to content

Replace all bell identifiers by enum class

Alex requested to merge 987-bell-type-enum into master

Closes #987 (closed)

What does this MR do?

Collects all identifiers for bells that we currently use (strings like 'new-fairteiler-') in a class BellType and replaces all usage with the constants in that class.

How confident are you it won't break things if deployed?

Very sure. This can only break something if there's a typo. I would be happy if you can check that.

Checklist

  • added a test, or explain why one is not needed/possible: only refactoring
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • add a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.

Merge request reports