Refactoring in Session and PageHelper group handling, fix #965
Closes #965 (closed)
What does this MR do?
- Ambassadors can access "manage group" for workgroups in their region from topbar: #965 (closed)
- refactor and simplify some Session / PageHelper code
- please review commit-by-commit
How confident are you it won't break things if deployed?
this is very old code, and some of it only triggers upon re-login. careful review (please go commit-by-commit) and more testing would be very appreciated.
Links to related issues
How to test
See #965 (closed) for the bugfix, and play around (including logout/login) with various scenarios that involve workgroup and region membership.
Checklist
-
no changes intended => no test (although checking the UI might make sense, if we have such a test scenario that could cover this) -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
use "state:" labels to track this MR's state until it was beta tested -
added an entry to CHANGELOG.md -
add a short text that can be used in the release notes -
Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo
Release notes text
see #965 (closed) for now