Skip to content

Docker compose updates

Nick Sellen requested to merge docker-compose-updates into master

Closes foodsharing-dev/issues0#266

What does this MR do?

An assortment of changes to improve execution of docker-compose environments:

  • db migrations now concatenated and run in one step
  • no longer build and pull images on start/test
  • use versioned images (so we don't need to keep checking with --pull for updates)
  • add ./scripts/rebuild-all command for the cases where you do need to rebuild
  • install npm deps using yarn in the container command (so happens in parallel with other containers starting up and simplifies scripts)
  • mark chat container as depending on redis (caused some test failures before as it wasn't ready in time, so chat didn't start, then web couldn't start...)
  • remove tests/seed.sql, seems it was not being used as tests still pass... caused some confusion

How confident are you it won't break things if deployed?

It is only touching dev/test/ci environments, so should be ok. Potentially people will need to run ./scripts/rebuild-all sometimes now though... if you make a change that would require this, then you should add mention this in the changelog...

Links to related issues

Checklist

  • added a test, or explain why one is not needed/possible... dev/test/ci env only...
  • no unrelated changes (debatable)
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))

Merge request reports