Skip to content

Minor frontend helper modernization: hiddenDialog, flashMessage

Chris Oelmueller requested to merge rename-xhr-hidden-dialog into master

What does this MR do?

  • Implement and use FlashMessageHelper:success
  • Unify + correct signatures of three similar helpers
  • Deprecate hiddenDialog and make it easier to work with what's left
  • Remove obsolete v_dialog_button

Recommendation: review each commit by itself.

How confident are you it won't break things if deployed?

if anything should break, it's just in the UI ;-)

Links to related issues

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
Edited by Chris Oelmueller

Merge request reports