Skip to content

Fix last creation date in pass generation table

Alex requested to merge 686-fix-pass-last-date into master

Closes #686

What does this MR do?

The date of last pass generation is not properly stored in fs_pass_gen table when generating multiple passes at once because of a wrong sql query. The table is then showing wrong dates.

How confident are you it won't break things if deployed?

Very sure

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Checkout branch locally
  2. Login as bot
  3. Go to a pass generation table: region -> 'Ausweise'
  4. Select multiple people and generate their passes
  5. Reload the page -> the dates should be updated

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • add a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.

Release notes text

  • Bei der Ausweiserstellung für mehrere fodsaver gleichzeitig wird nun bei allen das gleiche Datum gespeichert.

(A short text that will appear in the release notes and describes the change for non-technical people. Not always necessary, e.g. not for refactoring.)

Edited by -

Merge request reports