Skip to content

DTOs and endpoints for dashboard settings

Alex requested to merge dashboard-activity-DTOs into master

Some more &9 refactoring

What does this MR do?

Moves the dashboard activity settings to new REST endpoints GET /activities/options and PATCH /activities/options, adds some DTOs for that, and removes the corresponding Xhr code.

After this, GET /activities could be created for the dashboard updates.

How confident are you it won't break things if deployed?

Seems to work for me, but I'd be happy about more testing

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Checkout branch locally
  2. Login as foodsaver
  3. Open the dashboard options (gear wheel icon next to the filters)
  4. Deactivate some of them and save
  5. Close the options (same icon) and open them again
  6. The deactivated items should still be deactivated

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • add a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.
Edited by Chris Oelmueller

Merge request reports