Skip to content

Follow-up from voting tool: visible future options and confirm dialog

Alex requested to merge 975-make-future-options-visible into master

Closes #975

What does this MR do?

  • makes options visible even if you can't vote in a poll or if the poll has not yet started
  • shows a confirm dialog before submitting the vote with a warning that the vote cannot be changed later

How confident are you it won't break things if deployed?

Quite sute, should work

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Checkout branch locally
  2. Login as foodsaver
  3. Go to the region's polls
  4. Open a future poll -> you should be able to see the options, but no submit button
  5. Go to a running poll and vote -> you should see a confirm dialog

Screenshots (if applicable)

screenshot

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • set a "for:" label to indicate who will be affected by this change
  • use "state:" labels to track this MR's state until it was beta tested
  • added an entry to CHANGELOG.md
  • add a short text that can be used in the release notes
  • Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo:
    • Consider writing a detailed description in German.
    • Describe in a few sentences, what should be tested from a user perspective.
    • Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
    • Be aware, that also non technical people should understand.

Merge request reports