Use REST for the registration request
Closes #819 (closed)
What does this MR do?
Replaces the registration request which is called at the end of the registration form by a new REST endpoint POST /user
. Unfortunately this has become a rather large MR because it also removes all the obsolete code and adds a DTO that carries the registration data.
How confident are you it won't break things if deployed?
Works for me, but I'm not very sure
How to test
Steps a reviewer can take to verify that this MR does what it says it does e.g.
- Checkout branch locally
- Go to the registration page http://localhost:18080/?page=content&sub=joininfo
- Fill out the registration form
- See if you can submit the form in the end and are successfully registered
- Test if you can log in as the created user
- Check on http://localhost:18084/ if the activation email was sent
Checklist
-
added a test, or explain why one is not needed/possible... I reused the previous tests -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
use "state:" labels to track this MR's state until it was beta tested -
added an entry to CHANGELOG.md -
add a short text that can be used in the release notes(for:Dev) -
Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo: - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
- Be aware, that also non technical people should understand.