Bugfix for viewer ID in ProfileView
What does this MR do?
$viewerId = $this->session->id() || -1
in ProfileControl
was interpreted as boolean and always set to 1. For example, the "Ich kenne..." button was visible even on the profile page of buddies.
I think it's too tiny for changelog and release notes
How confident are you it won't break things if deployed?
Very sure
How to test
Steps a reviewer can take to verify that this MR does what it says it does e.g.
- Checkout branch locally
- Login as foodsaver and send a buddy request to another user
- Login as the other user and accept the request
- Both users should not see the buddy request button anymore
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
set a "for:" label to indicate who will be affected by this change -
use "state:" labels to track this MR's state until it was beta tested -
added an entry to CHANGELOG.md -
add a short text that can be used in the release notes -
Once your MR has been merged, you are responsible to create a testing issue in Beta Testing Repo: - Consider writing a detailed description in German.
- Describe in a few sentences, what should be tested from a user perspective.
- Also mention different settings (e.g. different browsers, roles, ...). how this change can be tested.
- Be aware, that also non technical people should understand.