Skip to content

Replace old tagedit autocomplete with existing search endpoint

Alex requested to merge tagedit-rest-search into master

What does this MR do?

Removes one of the old functions from XhrMethods that performed the autocomplete search for the tagedit fields and replaces it with the existing user search endpoint. The behavior shouldn't change but it removes some more old code.

How confident are you it won't break things if deployed?

Seems to work for me, but I'm not 100% sure if it could fail in any case

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Checkout branch locally

  2. Login as orga

  3. Go to the region admin tool http://localhost:18080/?page=region

  4. Select a region on the right side

  5. Try to set a new ambassador for the region on the left side and check if autocomplete works

  6. Go to any work group

  7. Open the edit page for that group

  8. Try to add group members or admins and check if autocomplete works

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
  • Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings
Edited by Chris Oelmueller

Merge request reports