Skip to content

Registration email check with rest

Alex requested to merge 819-registration-rest into master

Part of #819 (closed)

What does this MR do?

Moves the check whether an email address is valid for registration to a rest endpoint. The registration form can call this earlier so that you don't have to go back all steps of the form to change the email.

How confident are you it won't break things if deployed?

Backend: quite sure, I added some unit tests Frontend: ?

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Checkout branch locally
  2. Open the registration form http://localhost:18080/?page=register
  3. Enter an exist or not exist email address (e.g. user1.example.com is already exist in seed data)
  4. You should see an error message below the field

Front-end behavior for valid, invalid, and already registered email addresses:

ok error_invalid error_existing

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
  • Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings
Edited by Christian Walgenbach

Merge request reports