Skip to content

Leaving region by rest instead of xhr

Alex requested to merge 798-leave-region into master

Part of #798 (closed)

What does this MR do?

Moves the requests for leaving a region from Xhr to a new endpoint POST region/{regionId}/leave similar to the join endpoint. The server-side logic is still the same.

How confident are you it won't break things if deployed?

95%, it works locally for all cases that I tested

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Checkout branch locally
  2. Login as foodsaver
  3. Go to any region's page and try to leave a region
  4. Check if you really left the region

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
  • Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings

References

!1478 (merged)

Edited by Chris Oelmueller

Merge request reports