Skip to content
GitLab
    • GitLab: the DevOps platform
    • Explore GitLab
    • Install GitLab
    • How GitLab compares
    • Get started
    • GitLab docs
    • GitLab Learn
  • Pricing
  • Talk to an expert
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
    • Switch to GitLab Next
    Projects Groups Topics Snippets
  • Register
  • Sign in
  • F foodsharing
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 362
    • Issues 362
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 24
    • Merge requests 24
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Insights
    • Issue
    • Repository
  • External wiki
    • External wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • foodsharing-devfoodsharing-dev
  • foodsharing
  • Merge requests
  • !1457

Refactoring: Introduce DTO classes for bell notifications

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jano requested to merge refactor_bells into master Apr 25, 2020
  • Overview 6
  • Commits 16
  • Pipelines 10
  • Changes 19

What does this MR do?

This MR is about putting some order into the different formats of array representations used in method interfaces and HTTP APIs thoughout the foodsharing code.

How confident are you it won't break things if deployed?

Quite. It should not change anything in how the site works, just refactoring.

How to test

  1. Checkout branch locally
  2. Login as foodsaver
  3. Do bell related stuff and see nothing breaks

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
  • Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: refactor_bells