Skip to content

Show push notification banner also on foodsharer dashboard

Jano requested to merge show_push_notification_banner_also_on_foodsharer_dashboard into master

Closes #857 (closed) (and much confusion among testers)

What does this MR do?

This MR makes the push notification banner also appear on the dashboard that users see who haven't done the quiz yet. This dashbaord didn't show the banner before, which confused people, but also it confused the JavaScript which is the same for both dashboards an threw a TypeError on the foodsharer dashboard (see #857 (closed)).

How confident are you it won't break things if deployed?

Very. This is the same banner that already works for everyone except foodsharers.

How to test

  1. Checkout branch locally
  2. Login as foodsharer (create an account, it's simple as no confirmation mail is needed)
  3. Be advertised about push notifications

Screenshots (if applicable)

This pretty much looks the same as the one for foodsavers. See !734 (merged)

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s)) // belongs to Add Web Push Notifications IMHO
  • Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings
Edited by Jano

Merge request reports