Skip to content

Css fix in "Hidden broadcast overlay message" for mobile devices if they are in landscape format

Christian Walgenbach requested to merge fix-broadcast-banner3 into master

Closes no issue

What does this MR do?

Fix css for mobile devices if they are in landscape format and the broadcast message is placed in the middle.

How confident are you it won't break things if deployed?

very

Links to related issues

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Checkout branch locally
  2. Login as orgauser
  3. Put content into broadcast_info (content 51). This enables that text being shown on every page.
    http://localhost:18080/?page=content&a=edit&id=51
  4. Test in different browser and devices (in portrait and landscape format logged in and not logged in)

Screenshots (if applicable)

Broken version from master:

broadcaster-banner-master2

broadcaster-banner-master1

broadcaster-banner-master4

broadcaster-banner-master3

broadcaster-banner-master6

broadcaster-banner-master5

Fixed version:

fix-broadcaster-banner1

fix-broadcaster-banner2

fix-broadcaster-banner3

fix-broadcaster-banner4

fix-broadcaster-banner5

fix-broadcaster-banner6

fix-broadcaster-banner8

fix-broadcaster-banner7

fix-broadcast-banner

fix-broadcaster-banner9

Checklist

  • added a test, or explain why one is not needed/possible...
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
  • Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings
Edited by Christian Walgenbach

Merge request reports