Fixes wrong picture size of forum posts
Because of !1298 (merged) the profile pictures of forum posts got too big if the text was longer than the height of the picture.
What does this MR do?
For Avatar component a boolean auto scale was introduced, so that the profile picture either takes the full height of parent component or just uses the height/width of the picture and does not resize.
How confident are you it won't break things if deployed?
Confident.
Links to related issues
Any relevant links (issues, documentation, slack discussions):
https://yunity.slack.com/archives/C1T1ZM9A4/p1585998091167200
How to test
Steps a reviewer can take to verify that this MR does what it says it does e.g.
- Checkout branch locally
- Login as foodsaver
- Go to some forum site (e.g. http://localhost:18080/?page=bezirk&bid=341&sub=forum&tid=29125)
- Comment a long text, so that text uses more height than profile picture.
- Picture should stay the same height all the time.
Screenshots (if applicable)
Any relevant screenshots if this is a design / frontend change:
Checklist
-
added a test, or explain why one is not needed/possible... -
no unrelated changes -
asked someone for a code review -
joined #foodsharing-beta channel at https://slackin.yunity.org -
added an entry to CHANGELOG.md (description, merge request link, username(s)) -
Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings
Edited by Rafael