Skip to content

Fix startup for macOS

Christian Wansart requested to merge fix-startup-for-macos into master

What does this MR do?

macOS seem to fail to start the client container which is caused by missing permissions. It seems that on Linux this is not an issue, since $UID used in ./scripts/start has the correct value there. To be sure it is always correct I replaced the $UID by node:node and also used the home folder of the container described here: https://github.com/nodejs/docker-node/blob/master/README.md#create-a-dockerfile-in-your-nodejs-app-project

How confident are you it won't break things if deployed?

Totally. I tested it on macOS and Linux. I'd be great of some Windows user could test it as well.

Links to related issues

Any relevant links (issues, documentation, slack discussions).

How to test

Steps a reviewer can take to verify that this MR does what it says it does e.g.

  1. Run ./scripts/start
  2. Check the client logs docker logs foodsharing_dev_client. If there is no EACCES: permission denied ... you're good.

Screenshots (if applicable)

This is the error in my Docker log:

Bildschirmfoto_2020-03-29_um_12.08.56

Checklist

  • added a test, or explain why one is not needed/possible... <-- we have no infrastructure tests
  • no unrelated changes
  • asked someone for a code review
  • joined #foodsharing-beta channel at https://slackin.yunity.org
  • added an entry to CHANGELOG.md (description, merge request link, username(s))
  • Once your MR has been merged, you are responsible to update the #foodsharing-beta Slack channel about what has been changed here. They will test your work in different browsers, roles or other settings

Merge request reports